linux-kernel - Re: [PATCH] scsi: libfc: fix incorrect variable assingment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1494591672.1081.10.camel@localhost.localdomain>
Date:   Fri, 12 May 2017 08:21:12 -0400
From:   "Ewan D. Milne" <emilne@...hat.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Johannes Thumshirn <jth@...nel.org>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        fcoe-devel@...n-fcoe.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: libfc: fix incorrect variable assingment

On Thu, 2017-05-11 at 17:24 -0500, Gustavo A. R. Silva wrote:
> Previous assignment was causing the use of the uninitialized variable
> _explan_ inside fc_seq_ls_rjt() function, which in this particular
> case is being called by fc_seq_els_rsp_send().
> 
> Addresses-Coverity-ID: 1398125
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  drivers/scsi/libfc/fc_rport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
> index b44c313..5203258 100644
> --- a/drivers/scsi/libfc/fc_rport.c
> +++ b/drivers/scsi/libfc/fc_rport.c
> @@ -1422,7 +1422,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata,
>  	fp = fc_frame_alloc(lport, sizeof(*rtv));
>  	if (!fp) {
>  		rjt_data.reason = ELS_RJT_UNAB;
> -		rjt_data.reason = ELS_EXPL_INSUF_RES;
> +		rjt_data.explan = ELS_EXPL_INSUF_RES;
>  		fc_seq_els_rsp_send(in_fp, ELS_LS_RJT, &rjt_data);
>  		goto drop;
>  	}

s/assingment/assignment/

Reviewed-by: Ewan D. Milne <emilne@...hat.com>