linux-kernel - Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 May 2017 07:03:19 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chris Healy <Chris.Healy@....aero>, Jeff.White@....aero
Subject: Re: [PATCH] pinctrl: when claiming hog, skip maps not served by same
 device

* Nikita Yushchenko <nikita.yoush@...entembedded.com> [170512 01:22]:
> >> +		/*
> >> +		 * If pctldev is not null, we are claiming hog for it,
> >> +		 * that means, setting that is served by pctldev by itself.
> >> +		 *
> >> +		 * Thus we must skip map that is for this device but is served
> >> +		 * by other device.
> >> +		 */
> >> +		if (pctldev &&
> >> +		    strcmp(dev_name(pctldev->dev), map->ctrl_dev_name))
> >> +			continue;
> >>  
> >>  		ret = add_setting(p, pctldev, map);
> >>  		/*
> >> -- 
> > 
> > Maybe add a comment saying pctldev is NULL in the regular case
> > and only exists in the hog case?
> 
> Isn't comment above saying exactly that?

Yes it is, you're right :)

Tony