linux-kernel - Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrUVb8KqOOzW7fXDWCyCiXj6jpPm-w=XZ-FXrh_rfdDkJQ@mail.gmail.com>
Date:   Fri, 12 May 2017 07:04:42 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Mario.Limonciello@...l.com
Cc:     Andrew Lutomirski <luto@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-nvme <linux-nvme@...ts.infradead.org>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH] nvme: Change our APST table to be no more aggressive than
 Intel RSTe

On Fri, May 12, 2017 at 6:58 AM,  <Mario.Limonciello@...l.com> wrote:
>> Some testing reports suggest that this will fix the issues we've
>> seen on Dell laptops.
>
> It think it also makes sense to revert the quirk that was created based upon the previous aggressiveness of re-entry to PS4 on those machines.  Are you expecting to split that up into a second patch also targeted at 4.11 stable and 4.12, but later after some more testing?

Yes, mostly.  I've written the patch, but I was planning to target it
at 4.12 or 4.13 but not -stable.  It's mostly just a cleanup and has
no real power saving benefit since the RSTe timeouts are so absurdly
conservative that I doubt PS4 will happen in practical usage.  Perhaps
in suspend-to-idle?  (For suspend-to-idle, I suspect we should really
be using D3 instead.  Do we already do that?)