[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20170512174751.GB17235@fury>
Date: Fri, 12 May 2017 10:47:51 -0700
From: Darren Hart <dvhart@...radead.org>
To: Hans de Goede <hdegoede@...hat.com>
Cc: Andy Shevchenko <andy@...radead.org>,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] platform/x86: peaq-wmi: Add new peaq-wmi driver
On Fri, May 12, 2017 at 05:11:54PM +0200, Hans de Goede wrote:
> PEAQ is a new European OEM, I've bought one of their 2-in-1 x86
> devices, which is actually quite a nice device. Under Windows it has
> Dolby software for "better" sound and you can select different equalizer
> presets using a special button.
>
> This WMI interface for this button is not really nice, as it does not do
> notifies (it really does not I tripple checked), but since I had already
> figured out the entire WMI interface for this I decided to go the full
> mile anyways and also implent a WMI based input driver for this using
> input_polldev since, well, we need to poll.
>
> This commit adds support for this button making it report KEY_SOUND input
> events. KEY_SOUND is already used in various places to switch sound into
> theatre mode and things like that so it seems appropriate here.
>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
Queued to testing, thanks.
--
Darren Hart
VMware Open Source Technology Center
Powered by blists - more mailing lists