linux-kernel - Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrUh0TB6b5UKfYjFLVcciYppTrPGyJNhpj5W0Z7vgngyMw@mail.gmail.com>
Date:   Fri, 12 May 2017 16:49:01 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Mario.Limonciello@...l.com
Cc:     Andrew Lutomirski <luto@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-nvme <linux-nvme@...ts.infradead.org>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH] nvme: Change our APST table to be no more aggressive than
 Intel RSTe

On Fri, May 12, 2017 at 7:34 AM,  <Mario.Limonciello@...l.com> wrote:
>>Yes, mostly.  I've written the patch, but I was planning to target it
>>at 4.12 or 4.13 but not -stable.  It's mostly just a cleanup and has
>>no real power saving benefit since the RSTe timeouts are so absurdly
>>conservative that I doubt PS4 will happen in practical usage.
> OK.
>
>>Perhaps
>>in suspend-to-idle?  (For suspend-to-idle, I suspect we should really
>>be using D3 instead.  Do we already do that?)
>
> Well I think this will depend upon what the SSD "will" support.

I thought it was basically impossible for the SSD to fail to support
D3.  Afterall, cutting the power due to runtime D3 is more or less the
same thing (from the SSD's POV) as cutting the power during S3 or full
power off.

I've contemplated adding runtime D3 support to the nvme driver, but it
would probably be barely a win and quite slow.

When Linux suspends-to-idle, does it call driver suspend callbacks and
kick devices into D3?  It should work, but I don't know what actually
happens.