lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 13 May 2017 16:54:10 +0300
From:   Andy Shevchenko <>
To:     Jan Kiszka <>
Cc:     Greg Kroah-Hartman <>,
        Linus Walleij <>,
        Alexandre Courbot <>,
        Linux Kernel Mailing List <>,
        "" <>,
        "" <>,
        Sudip Mukherjee <>,
        Sascha Weisenberger <>
Subject: Re: [PATCH 8/8] serial: exar: Add support for IOT2040 device

On Sat, May 13, 2017 at 10:29 AM, Jan Kiszka <> wrote:
> This implements the setup of RS232 and the switch-over to RS485 or RS422
> for the Siemens IOT2040. That uses an EXAR XR17V352 with external logic
> to switch between the different modes. The external logic is controlled
> via MPIO pins of the EXAR controller.
> Only pin 10 can be exported as GPIO on the IOT2040. It is connected to
> an LED.
> As the XR17V352 used on the IOT2040 is not equipped with an external
> EEPROM, it cannot present itself as IOT2040-variant via subvendor/
> subdevice IDs. Thus, we have to check via DMI for the target platform.
> Co-developed with Sascha Weisenberger.

Please, refactor that using properly formed DMI structrure and use its
callback and driver data facilities/

stmmac's pattern that you obviously applied does not actually suit here.

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists