linux-kernel - Re: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3956756.APWK7IdRuP@phil>
Date:   Sat, 13 May 2017 17:43:40 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Ian Campbell <ijc@...lion.org.uk>
Cc:     linux-kernel@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include

Hi Ian,

Am Samstag, 13. Mai 2017, 00:53:57 CEST schrieb Ian Campbell:
> It not necessary and counter to how all the other files are done.
> 
> It also happens to break the build in the split device tree repo
> https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/
> 
> Signed-off-by: Ian Campbell <ijc@...lion.org.uk>
> Cc: Brian Norris <briannorris@...omium.org>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will.deacon@....com>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-rockchip@...ts.infradead.org
> Cc: linux-kernel@...r.kernel.org

that glitch also breaks Olof's patch [0] fixing a depmod symlink
recursion in that it creates

../arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:47:57: fatal error: include/dt-bindings/input/linux-event-codes.h: File or directory not found
 #include <include/dt-bindings/input/linux-event-codes.h>

with only Olof's patch applied. So I guess both patches should go
together with this one in front, so to be on the safe side, if some else
is going to apply both:

Reviewed-by: Heiko Stuebner <heiko@...ech.de>


[0] https://www.spinics.net/lists/arm-kernel/msg580846.html