lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 13 May 2017 12:00:10 -0700 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Al Viro <viro@...iv.linux.org.uk> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org> Subject: Re: [git pull] uaccess-related bits of vfs.git On Sat, May 13, 2017 at 11:04 AM, Al Viro <viro@...iv.linux.org.uk> wrote: > > > My point is, this stuff needs looking at. No. You don't have a point. I've tried to explain that there's no performance difference, and there is no way in hell that the current "__" versions are better. So what's the point in looking? All you are ever going to come up with is theoretical "this might" cases. The only sane forward is to just get rid of them. At that point, you *may* end up actually noticing something, but if you do, it's not a "you might" issue. There's literally no upside to this "needs looking at". There are only downsides. And one major downside of your "needs looking at". is this one: From: Linus Torvalds <torvalds@...ux-foundation.org> Date: Tue, 24 Mar 2015 10:42:18 -0700 > > So I'd suggest we should just do a wholesale replacement of > __copy_to/from_user() with the non-underlined cases. Then, we could > switch insividual ones back - with reasoning of why they matter, and > with pointers to how it does access_ok() two lines before. > > We should probably even consider looking at __get_user/__put_user(). > Few of them are actually performance-critical. Look at that date. It's over two years ago. In the intervening two years, how many of those conversions have happened? Here's a hint: it's a very very round number. Linus
Powered by blists - more mailing lists