linux-kernel - [PATCH v2] usb: misc: legousbtower: Fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 13 May 2017 23:49:26 +0300
From:   Maksim Salau <maksim.salau@...il.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Juergen Stuber <starblue@...rs.sourceforge.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        legousb-devel@...ts.sourceforge.net, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alfredo Rafael Vicente Boix <alviboi@...il.com>
Cc:     Maksim Salau <maksim.salau@...il.com>
Subject: [PATCH v2] usb: misc: legousbtower: Fix memory leak

get_version_reply is not freed if function returns with success.

Fixes: 942a48730faf ("usb: misc: legousbtower: Fix buffers on stack")
Reported-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Signed-off-by: Maksim Salau <maksim.salau@...il.com>
---

 v2:
 Changed tags to match guidelines.

 drivers/usb/misc/legousbtower.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c
index aa3c280fdf8d..0782ac6f5edf 100644
--- a/drivers/usb/misc/legousbtower.c
+++ b/drivers/usb/misc/legousbtower.c
@@ -926,6 +926,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device
 		 USB_MAJOR, dev->minor);
 
 exit:
+	kfree(get_version_reply);
 	return retval;
 
 error:
-- 
2.9.3