lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 14 May 2017 16:42:36 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     eddi1983 <eddi1983@....net>, lars@...afoo.de
Cc:     Michael Hennerich <Michael.Hennerich@...log.com>,
        Hartmut Knaack <knaack.h@....de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: meter: ade7854: Fix symbolic permissions to
 octal permissions

On 08/05/17 21:10, eddi1983 wrote:
> From: Christoph Fanelsa <eddi1983@....net>
> 
> Fixed the checkpatch warnings (task #10 of eudyptula challenge) of prefered
> octal permissions over symbolic ones
> 
> Signed-off-by: Christoph Fanelsa <eddi1983@....net>
> Cc: Michael Hennerich <Michael.Hennerich@...log.com>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Hartmut Knaack <knaack.h@....de>
> Cc: Peter Meerwald-Stadler <pmeerw@...erw.net>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-iio@...r.kernel.org
> Cc: devel@...verdev.osuosl.org
> Cc: linux-kernel@...r.kernel.org
Already have a patch applied to do this.

Note that IIO patches take a slightly less direct route to Greg's
staging tree than most other staging patches.  They go through the
IIO tree first which can be found at:

https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/

Of particular interest is the togreg branch and the testing branch
which can also let you see more recent stuff.

Jonathan


>   drivers/staging/iio/meter/ade7854.c | 88 ++++++++++++++++++-------------------
>   1 file changed, 44 insertions(+), 44 deletions(-)
> 
> diff --git a/drivers/staging/iio/meter/ade7854.c b/drivers/staging/iio/meter/ade7854.c
> index c6cffc11b0ba..70612da64a8b 100644
> --- a/drivers/staging/iio/meter/ade7854.c
> +++ b/drivers/staging/iio/meter/ade7854.c
> @@ -186,127 +186,127 @@ static int ade7854_reset(struct device *dev)
>   	return st->write_reg_16(dev, ADE7854_CONFIG, val);
>   }
>   
> -static IIO_DEV_ATTR_AIGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_AIGAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_AIGAIN);
> -static IIO_DEV_ATTR_BIGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_BIGAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_BIGAIN);
> -static IIO_DEV_ATTR_CIGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CIGAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_CIGAIN);
> -static IIO_DEV_ATTR_NIGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_NIGAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_NIGAIN);
> -static IIO_DEV_ATTR_AVGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_AVGAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_AVGAIN);
> -static IIO_DEV_ATTR_BVGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_BVGAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_BVGAIN);
> -static IIO_DEV_ATTR_CVGAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CVGAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_CVGAIN);
> -static IIO_DEV_ATTR_APPARENT_POWER_A_GAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_APPARENT_POWER_A_GAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_AVAGAIN);
> -static IIO_DEV_ATTR_APPARENT_POWER_B_GAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_APPARENT_POWER_B_GAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_BVAGAIN);
> -static IIO_DEV_ATTR_APPARENT_POWER_C_GAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_APPARENT_POWER_C_GAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_CVAGAIN);
> -static IIO_DEV_ATTR_ACTIVE_POWER_A_OFFSET(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_ACTIVE_POWER_A_OFFSET(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_AWATTOS);
> -static IIO_DEV_ATTR_ACTIVE_POWER_B_OFFSET(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_ACTIVE_POWER_B_OFFSET(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_BWATTOS);
> -static IIO_DEV_ATTR_ACTIVE_POWER_C_OFFSET(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_ACTIVE_POWER_C_OFFSET(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_CWATTOS);
> -static IIO_DEV_ATTR_REACTIVE_POWER_A_GAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_REACTIVE_POWER_A_GAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_AVARGAIN);
> -static IIO_DEV_ATTR_REACTIVE_POWER_B_GAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_REACTIVE_POWER_B_GAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_BVARGAIN);
> -static IIO_DEV_ATTR_REACTIVE_POWER_C_GAIN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_REACTIVE_POWER_C_GAIN(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_CVARGAIN);
> -static IIO_DEV_ATTR_REACTIVE_POWER_A_OFFSET(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_REACTIVE_POWER_A_OFFSET(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_AVAROS);
> -static IIO_DEV_ATTR_REACTIVE_POWER_B_OFFSET(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_REACTIVE_POWER_B_OFFSET(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_BVAROS);
> -static IIO_DEV_ATTR_REACTIVE_POWER_C_OFFSET(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_REACTIVE_POWER_C_OFFSET(0644,
>   		ade7854_read_24bit,
>   		ade7854_write_24bit,
>   		ADE7854_CVAROS);
> -static IIO_DEV_ATTR_VPEAK(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_VPEAK(0644,
>   		ade7854_read_32bit,
>   		ade7854_write_32bit,
>   		ADE7854_VPEAK);
> -static IIO_DEV_ATTR_IPEAK(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_IPEAK(0644,
>   		ade7854_read_32bit,
>   		ade7854_write_32bit,
>   		ADE7854_VPEAK);
> -static IIO_DEV_ATTR_APHCAL(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_APHCAL(0644,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_APHCAL);
> -static IIO_DEV_ATTR_BPHCAL(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_BPHCAL(0644,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_BPHCAL);
> -static IIO_DEV_ATTR_CPHCAL(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CPHCAL(0644,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_CPHCAL);
> -static IIO_DEV_ATTR_CF1DEN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CF1DEN(0644,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_CF1DEN);
> -static IIO_DEV_ATTR_CF2DEN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CF2DEN(0644,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_CF2DEN);
> -static IIO_DEV_ATTR_CF3DEN(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CF3DEN(0644,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_CF3DEN);
> -static IIO_DEV_ATTR_LINECYC(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_LINECYC(0644,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_LINECYC);
> -static IIO_DEV_ATTR_SAGCYC(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_SAGCYC(0644,
>   		ade7854_read_8bit,
>   		ade7854_write_8bit,
>   		ADE7854_SAGCYC);
> -static IIO_DEV_ATTR_CFCYC(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_CFCYC(0644,
>   		ade7854_read_8bit,
>   		ade7854_write_8bit,
>   		ADE7854_CFCYC);
> -static IIO_DEV_ATTR_PEAKCYC(S_IWUSR | S_IRUGO,
> +static IIO_DEV_ATTR_PEAKCYC(0644,
>   		ade7854_read_8bit,
>   		ade7854_write_8bit,
>   		ADE7854_PEAKCYC);
> @@ -318,55 +318,55 @@ static IIO_DEV_ATTR_ANGLE1(ade7854_read_24bit,
>   		ADE7854_ANGLE1);
>   static IIO_DEV_ATTR_ANGLE2(ade7854_read_24bit,
>   		ADE7854_ANGLE2);
> -static IIO_DEV_ATTR_AIRMS(S_IRUGO,
> +static IIO_DEV_ATTR_AIRMS(0444,
>   		ade7854_read_24bit,
>   		NULL,
>   		ADE7854_AIRMS);
> -static IIO_DEV_ATTR_BIRMS(S_IRUGO,
> +static IIO_DEV_ATTR_BIRMS(0444,
>   		ade7854_read_24bit,
>   		NULL,
>   		ADE7854_BIRMS);
> -static IIO_DEV_ATTR_CIRMS(S_IRUGO,
> +static IIO_DEV_ATTR_CIRMS(0444,
>   		ade7854_read_24bit,
>   		NULL,
>   		ADE7854_CIRMS);
> -static IIO_DEV_ATTR_NIRMS(S_IRUGO,
> +static IIO_DEV_ATTR_NIRMS(0444,
>   		ade7854_read_24bit,
>   		NULL,
>   		ADE7854_NIRMS);
> -static IIO_DEV_ATTR_AVRMS(S_IRUGO,
> +static IIO_DEV_ATTR_AVRMS(0444,
>   		ade7854_read_24bit,
>   		NULL,
>   		ADE7854_AVRMS);
> -static IIO_DEV_ATTR_BVRMS(S_IRUGO,
> +static IIO_DEV_ATTR_BVRMS(0444,
>   		ade7854_read_24bit,
>   		NULL,
>   		ADE7854_BVRMS);
> -static IIO_DEV_ATTR_CVRMS(S_IRUGO,
> +static IIO_DEV_ATTR_CVRMS(0444,
>   		ade7854_read_24bit,
>   		NULL,
>   		ADE7854_CVRMS);
> -static IIO_DEV_ATTR_AIRMSOS(S_IRUGO,
> +static IIO_DEV_ATTR_AIRMSOS(0444,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_AIRMSOS);
> -static IIO_DEV_ATTR_BIRMSOS(S_IRUGO,
> +static IIO_DEV_ATTR_BIRMSOS(0444,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_BIRMSOS);
> -static IIO_DEV_ATTR_CIRMSOS(S_IRUGO,
> +static IIO_DEV_ATTR_CIRMSOS(0444,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_CIRMSOS);
> -static IIO_DEV_ATTR_AVRMSOS(S_IRUGO,
> +static IIO_DEV_ATTR_AVRMSOS(0444,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_AVRMSOS);
> -static IIO_DEV_ATTR_BVRMSOS(S_IRUGO,
> +static IIO_DEV_ATTR_BVRMSOS(0444,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_BVRMSOS);
> -static IIO_DEV_ATTR_CVRMSOS(S_IRUGO,
> +static IIO_DEV_ATTR_CVRMSOS(0444,
>   		ade7854_read_16bit,
>   		ade7854_write_16bit,
>   		ADE7854_CVRMSOS);
> 

Powered by blists - more mailing lists