linux-kernel - Re: [PATCH] staging: ccree: remove unused function argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOtvUMeMoUsP60R+2b1nRjas-kq8c1jqqwQxC5Ff1dOouwKZUg@mail.gmail.com>
Date:   Sun, 14 May 2017 09:34:24 +0300
From:   Gilad Ben-Yossef <gilad@...yossef.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: ccree: remove unused function argument

Hi Arnd,

On Thu, May 11, 2017 at 2:38 PM, Arnd Bergmann <arnd@...db.de> wrote:
> "gcc -Wunused" warns about one argument being assigned but not used:
>
> drivers/staging/ccree/ssi_cipher.c: In function 'ssi_blkcipher_complete':
> drivers/staging/ccree/ssi_cipher.c:747:41: error: parameter 'info' set but not used [-Werror=unused-but-set-parameter]
>
> We can simply drop that argument here and in its callers.
>
> Fixes: 302ef8ebb4b2 ("staging: ccree: add skcipher support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks for spotting this. There used to be some code that used this
parameter there, way back when.

The patch didn't apply after recent changes due to line moves so I
re-based it and also took the opportunity
to trim the > 80 char lines. I hope that is OK.

Thanks!
Gilad




-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru