linux-kernel - Re: [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 May 2017 16:24:44 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Harinath Nampally <harinath922@...il.com>, lars@...afoo.de
Cc:     Michael.Hennerich@...log.com, knaack.h@....de, pmeerw@...erw.net,
        gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] staging: iio: meter: Add the comment for mutex
 definition.

On 10/05/17 00:41, Harinath Nampally wrote:
> This patch fixes below checkpatch.pl warning:
> CHECK: struct mutex definition without comment
> 
> Signed-off-by: Harinath Nampally <harinath922@...il.com>
They description is no longer correct. This moves a comment
rather than adding one.

J
> ---
> Changes in v2:
>   - Removed the extra comment for mutex in the struct.
> 	
>   drivers/staging/iio/meter/ade7753.c | 3 ++-
>   1 file changed, 1 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c
> index b71fbd3..cffe6bf 100644
> --- a/drivers/staging/iio/meter/ade7753.c
> +++ b/drivers/staging/iio/meter/ade7753.c
> @@ -78,12 +78,13 @@
>   /**
>    * struct ade7753_state - device instance specific data
>    * @us:         actual spi_device
> + * @buf_lock:       mutex to protect tx and rx
>    * @tx:         transmit buffer
>    * @rx:         receive buffer
> - * @buf_lock:       mutex to protect tx and rx
>    **/
>   struct ade7753_state {
>   	struct spi_device   *us;
>   	struct mutex        buf_lock;
>   	u8          tx[ADE7753_MAX_TX] ____cacheline_aligned;
>   	u8          rx[ADE7753_MAX_RX];
>