linux-kernel - Re: [PATCH v3 3/9] dt-bindings: arm: mediatek: update for MT7623n SoC and relevant boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 May 2017 09:53:37 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     sean.wang@...iatek.com, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, john@...ozen.org,
        linux-mediatek@...ts.infradead.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/9] dt-bindings: arm: mediatek: update for MT7623n SoC
 and relevant boards



On 12/05/17 09:56, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> Because there are two versions of MT7623 SoC that is MT7623a and MT7623n
> respectively. So update the part of MT7623n bindings to allow that people
> tend to differentiate which MT7623 SoC the boards applies.
> 
> Signed-off-by: John Crispin <john@...ozen.org>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>   Documentation/devicetree/bindings/arm/mediatek.txt | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.txt b/Documentation/devicetree/bindings/arm/mediatek.txt
> index c860b24..0924b62 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.txt
> +++ b/Documentation/devicetree/bindings/arm/mediatek.txt
> @@ -1,6 +1,6 @@
>   MediaTek mt65xx, mt67xx & mt81xx Platforms Device Tree Bindings
>   
> -Boards with a MediaTek mt65xx/mt67xx/mt81xx SoC shall have the
> +Boards with a MediaTek mt65xx/mt67xx/mt762x/mt81xx SoC shall have the
>   following property:
>   
>   Required root node property:
> @@ -12,7 +12,7 @@ compatible: Must contain one of
>      "mediatek,mt6592"
>      "mediatek,mt6755"
>      "mediatek,mt6795"
> -   "mediatek,mt7623"
> +   "mediatek,mt7623" which is referred to MT7623N SoC
>      "mediatek,mt8127"
>      "mediatek,mt8135"
>      "mediatek,mt8173"
> @@ -38,9 +38,9 @@ Supported boards:
>   - Evaluation board for MT6795(Helio X10):
>       Required root node properties:
>         - compatible = "mediatek,mt6795-evb", "mediatek,mt6795";
> -- Evaluation board for MT7623:
> +- Reference  board for MT7623n with NAND:
>       Required root node properties:
> -      - compatible = "mediatek,mt7623-evb", "mediatek,mt7623";
> +      - compatible = "mediatek,mt7623n-rfb-nand", "mediatek,mt7623";

Please explain in the commit message why you change this binding and why 
this is not problematic. Either in this patch or add a new one.

For convenience for the device-tree maintainer, add the binding patches 
at the beginning of your patch list. It makes their life easier and a 
review faster, a clear win-win situation :)

Thanks,
Matthias

>   - MTK mt8127 tablet moose EVB:
>       Required root node properties:
>         - compatible = "mediatek,mt8127-moose", "mediatek,mt8127";
>