linux-kernel - [PATCH 1/2] ipack: Delete an error message for a failed memory allocation in ipack_device_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170515090810.15404-1-siglesias@igalia.com>
Date:   Mon, 15 May 2017 11:08:09 +0200
From:   Samuel Iglesias Gonsálvez 
        <siglesias@...lia.com>
To:     gregkh@...uxfoundation.org
Cc:     Markus Elfring <elfring@...rs.sourceforge.net>,
        jens.taprogge@...rogge.org,
        industrypack-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH 1/2] ipack: Delete an error message for a failed memory allocation in ipack_device_read_id()

From: Markus Elfring <elfring@...rs.sourceforge.net>

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
Acked-by: Samuel Iglesias Gonsálvez <siglesias@...lia.com>
---

Greg, Would you mind picking this patch series through your char-misc tree?

Sam

 drivers/ipack/ipack.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
index 12102448fddd..575c4f29e0f7 100644
--- a/drivers/ipack/ipack.c
+++ b/drivers/ipack/ipack.c
@@ -402,7 +402,6 @@ static int ipack_device_read_id(struct ipack_device *dev)
 	 * ID ROM contents */
 	dev->id = kmalloc(dev->id_avail, GFP_KERNEL);
 	if (!dev->id) {
-		dev_err(&dev->dev, "dev->id alloc failed.\n");
 		ret = -ENOMEM;
 		goto out;
 	}
-- 
2.11.0