linux-kernel - Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170515101235.uy776lopdsyd4h73@sirena.org.uk>
Date:   Mon, 15 May 2017 11:12:35 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Vignesh R <vigneshr@...com>, linux-spi <linux-spi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote:
> On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@...nel.org> wrote:
> > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
> >> If NO_DMA=y:

> >>     ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!

> >> Add a dependency on HAS_DMA to fix this.

> > There's no progress on fixing the architectures that don't do DMA to
> > stub it out?  :(

> Then it has to become "depends on HAS_DMA || COMPILE_TEST"?

No, I was thinking more just not needing the dependency at all.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)