linux-kernel - Re: [PATCH 3/9] staging: sm750fb: reordering of macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170515102011.GA31131@kroah.com>
Date:   Mon, 15 May 2017 12:20:11 +0200
From:   Greg KH <greg@...ah.com>
To:     Matej Dujava <mdujava@...urkovo.cz>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Teddy Wang <teddy.wang@...iconmotion.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/9] staging: sm750fb: reordering of macro definitions

On Sun, May 14, 2017 at 12:42:36AM +0200, Matej Dujava wrote:
> This patch reorder definition of macros so all macros are in same order.
> 
> Signed-off-by: Matej Dujava <mdujava@...urkovo.cz>
> ---
>  drivers/staging/sm750fb/ddk750_display.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h
> index 6f639d7..cef7f46 100644
> --- a/drivers/staging/sm750fb/ddk750_display.h
> +++ b/drivers/staging/sm750fb/ddk750_display.h
> @@ -81,8 +81,8 @@
>  #define DPMS_OFFSET	9
>  #define DPMS_MASK	(3 << DPMS_OFFSET)
>  #define DPMS_USAGE	(DPMS_MASK << 16)
> -#define DPMS_OFF	((3 << DPMS_OFFSET) | DPMS_USAGE)
>  #define DPMS_ON		((0 << DPMS_OFFSET) | DPMS_USAGE)
> +#define DPMS_OFF	((3 << DPMS_OFFSET) | DPMS_USAGE)

What "order" are you speaking of here?

I don't understand why this change is needed, sorry.

greg k-h