linux-kernel - Re: [PATCH v2] drivers/staging: refactor dgnc tty registration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170515115841.33uyk5xx26a773g7@mwanda>
Date:   Mon, 15 May 2017 14:58:41 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Haim Daniel <haimdaniel@...il.com>
Cc:     lidza.louina@...il.com, markh@...pro.net,
        gregkh@...uxfoundation.org, driverdev-devel@...uxdriverproject.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drivers/staging: refactor dgnc tty registration.

On Mon, May 15, 2017 at 02:48:52PM +0300, Haim Daniel wrote:
> +static struct tty_driver *_dgnc_tty_register(char *serial_name, uint maxports,


Ahh...  I see why you are adding underscores.  Please, just get a better
name instead of taking an existing name and adding underscores.

regards,
dan carpenter