linux-kernel - Re: [RFC/RFT PATCH v2 0/3] PCI: generic device NUMA node detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170515135157.GB9700@localhost.localdomain>
Date:   Mon, 15 May 2017 06:51:57 -0700
From:   Vadim Lomovtsev <Vadim.Lomovtsev@...iumnetworks.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc:     linux-pci@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Sergey Temerkhanov <s.temerkhanov@...il.com>,
        Sinan Kaya <okaya@...eaurora.org>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        Vadim.Lomovtsev@...iumnetworks.com
Subject: Re: [RFC/RFT PATCH v2 0/3] PCI: generic device NUMA node detection

On Mon, May 15, 2017 at 02:22:02PM +0100, Lorenzo Pieralisi wrote:
> This patch series is v2 of a previous posting:
> 
> v1 -> v2:
> 
> - Added missing call to acpi_pci_bus_find_numa_node()
> - Rebased against v4.12-rc1
> 
> v1: https://lkml.org/lkml/2017/4/26/211
> 
> On the ARM64 architecture, the arch specific PCI pcibus_to_node() callback
> can be triggered on struct pci_bus.sysdata structures that carry host
> bridge specific data through different structures layout (ie sysdata
> pointer points at different structs for different host bridges), therefore
> it is not possible to have a unified pcibus_to_node() implementation.
> 
> Given that the device NUMA node is a property of the struct pci_bus (and
> its associated struct device), move the struct pci_bus node assignment to
> generic PCI code, where according to the platform firmware the NUMA node
> for the device backing the struct pci_bus is retrieved and propagated
> through the PCI bus hierarchy.
> 
> Lorenzo Pieralisi (3):
>   PCI: Introduce pci_bus_find_numa_node()
>   PCI: Add call to set-up NUMA node for struct pci_bus devices
>   PCI/ACPI: Add ACPI pci_bus_find_numa_node() implementation
> 
>  drivers/pci/pci-acpi.c | 20 ++++++++++++++++++++
>  drivers/pci/pci.c      |  6 ++++++
>  drivers/pci/probe.c    |  3 ++-
>  include/linux/pci.h    |  7 +++++++
>  4 files changed, 35 insertions(+), 1 deletion(-)
>

Tested at dual-socketed system with Cavium ThunderX SoC.
Tested with 4.11 kernel.
No issues observed, numa_node value set appropriately for pci devices.

Tested-by: Vadim Lomovtsev <Vadim.Lomovtsev@...iumnetworks.com>

> -- 
> 2.10.0
> 


WBR,
Vadim