linux-kernel - [PATCH 2/2] coredump: call do_unlinkat directly instead of sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170515155922.1847-2-hch@lst.de>
Date:   Mon, 15 May 2017 17:59:22 +0200
From:   Christoph Hellwig <hch@....de>
To:     viro@...IV.linux.org.uk
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 2/2] coredump: call do_unlinkat directly instead of sys_unlink

And stop messing with the address limit.

Signed-off-by: Christoph Hellwig <hch@....de>
---
 fs/coredump.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index 592683711c64..10a020639a94 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -679,16 +679,11 @@ void do_coredump(const siginfo_t *siginfo)
 		 * privs and don't want to unlink another user's coredump.
 		 */
 		if (!need_suid_safe) {
-			mm_segment_t old_fs;
-
-			old_fs = get_fs();
-			set_fs(KERNEL_DS);
 			/*
 			 * If it doesn't exist, that's fine. If there's some
 			 * other problem, we'll catch it at the filp_open().
 			 */
-			(void) sys_unlink((const char __user *)cn.corename);
-			set_fs(old_fs);
+			do_unlinkat(AT_FDCWD, getname_kernel(cn.corename));
 		}
 
 		/*
-- 
2.11.0