linux-kernel - Re: [PATCH] cros_ec_i2c: prevent i2c timeout for EC_CMD_FLASH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=WBme4F165T8w3_xMH9rW1555F4h8PvzqDbHuuhLo_Skg@mail.gmail.com>
Date:   Mon, 15 May 2017 09:17:26 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Wei-Ning Huang <wnhuang@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Duncan Laurie <dlaurie@...gle.com>,
        Andrew de los Reyes <adlr@...omium.org>,
        Wei-Ning Huang <wnhuang@...gle.com>,
        Lee Jones <lee.jones@...aro.org>,
        Randall Spangler <rspangler@...omium.org>
Subject: Re: [PATCH] cros_ec_i2c: prevent i2c timeout for EC_CMD_FLASH_ERASE

Hi,

On Wed, May 10, 2017 at 10:30 PM, Wei-Ning Huang <wnhuang@...omium.org> wrote:
> Some EC chip has larger flash sector size which requires longer erase
> time. During erase the CPU is usually stalled and can't even respond to
> interrupts. We sleep a while to block any EC command from executing
> during the flash erase period.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@...gle.com>

Slightly odd here that your SoB and author don't match.  Patch is
listed as "From" your chromium address but SoB is your google one.


> ---
>  drivers/mfd/cros_ec_i2c.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
> index 9f70de1e4c70..8f23d5a8cc5b 100644
> --- a/drivers/mfd/cros_ec_i2c.c
> +++ b/drivers/mfd/cros_ec_i2c.c
> @@ -23,6 +23,14 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>
> +/*
> + * Some EC chip has larger flash sector size which requires longer erase time.
> + * During erase the CPU is usually stalled and can't even respond to
> + * interrupts. We sleep for a while to block any EC command from executing
> + * during the flash erase period to prevent i2c timeout.
> + */
> +#define EC_FLASH_ERASE_DELAY_MS        5000
> +
>  /**
>   * Request format for protocol v3
>   * byte 0      0xda (EC_COMMAND_PROTOCOL_3)
> @@ -177,6 +185,16 @@ static int cros_ec_pkt_xfer_i2c(struct cros_ec_device *ec_dev,
>
>         ret = ec_response->data_len;
>
> +       /*
> +        * If we get EC_RES_IN_PROGRESS for EC_CMD_FLASH_ERASE this means EC
> +        * need a long time to erase flash, during flash erase CPU is stalled
> +        * and can't respond to interrupts, so we sleep for a while to stop new
> +        * EC commands from communicating with EC.
> +        */
> +       if (msg->command == EC_CMD_FLASH_ERASE &&
> +           msg->result == EC_RES_IN_PROGRESS)
> +               msleep(EC_FLASH_ERASE_DELAY_MS);
> +
>  done:
>         if (msg->command == EC_CMD_REBOOT_EC)
>                 msleep(EC_REBOOT_DELAY_MS);


As per review that took place off-list on crosreview.com/502840, this
seems pretty sane to me.

Reviewed-by: Douglas Anderson <dianders@...omium.org>