linux-kernel - [PATCH 1/6] PNP: Delete an error message for a failed memory allocation in pnp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e1a8099-5f0b-d8f4-d039-7c3ecdf8b508@users.sourceforge.net>
Date:   Mon, 15 May 2017 21:12:26 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        kernel-janitors@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa@...-dreams.de>
Subject: [PATCH 1/6] PNP: Delete an error message for a failed memory
 allocation in pnp_alloc()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 15 May 2017 19:35:29 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/pnp/core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pnp/core.c b/drivers/pnp/core.c
index b54620e53830..27945a2d9c4e 100644
--- a/drivers/pnp/core.c
+++ b/drivers/pnp/core.c
@@ -35,10 +35,8 @@ void *pnp_alloc(long size)
 	void *result;
 
 	result = kzalloc(size, GFP_KERNEL);
-	if (!result) {
-		printk(KERN_ERR "pnp: Out of Memory\n");
+	if (!result)
 		return NULL;
-	}
 	return result;
 }
 
-- 
2.13.0