linux-kernel - [PATCH 6/6] PNP: Delete an error message for a failed memory allocation in quirk_awe32_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72ac25c7-93b8-49ad-bdb2-173aa2863aba@users.sourceforge.net>
Date:   Mon, 15 May 2017 21:22:00 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        kernel-janitors@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa@...-dreams.de>
Subject: [PATCH 6/6] PNP: Delete an error message for a failed memory
 allocation in quirk_awe32_add_ports()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 15 May 2017 20:36:35 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/pnp/quirks.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index f9be5f3fb7ea..ae7fbf105e0a 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -33,8 +33,5 @@ static void quirk_awe32_add_ports(struct pnp_dev *dev,
-	if (!new_option) {
-		dev_err(&dev->dev, "couldn't add ioport region to option set "
-			"%d\n", pnp_option_set(option));
+	if (!new_option)
 		return;
-	}
 
 	*new_option = *option;
 	new_option->u.port.min += offset;
-- 
2.13.0