linux-kernel - Re: [PATCHv2] watchdog: core: add option to avoid early handling of watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878tlxpycf.fsf@rasmusvillemoes.dk>
Date:   Tue, 16 May 2017 00:08:32 +0200
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Guenter Roeck <linux@...ck-us.net>,
        Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCHv2] watchdog: core: add option to avoid early handling of watchdog

On Sun, May 14 2017, Guenter Roeck wrote:

> On 05/12/2017 05:05 AM, Sebastian Reichel wrote:
>> On some systems its desirable to have watchdog reboot the system
>> when it does not come up fast enough. This adds a kernel parameter
>> to disable the auto-update of watchdog before userspace takes over
>> and a kernel option to set the default. The info messages were
>> added to shorten error searching on misconfigured systems.
>>
>> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>
>
> Minor nitpicks below (which I fixed up in my watchdog-next branch).
> Otherwise

Guenter, Sebastian, can I pursuade you to take a (second) look at the
patches [1] I sent 4 months ago that implement the same thing, except
that they also give a .config and a boot-cmdline way to define what
"fast enough" means - which is necessary in many cases where it's simply
not realistic to have userspace up-and-running before the dog is hungry.

[1] https://lkml.org/lkml/2017/1/9/408

I'm of course happy to rebase and retest those on top of current master,
but the implementation and semantics should be reviewable as-is.

Rasmus