linux-kernel - Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk to Intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKdAkRRp0M8sKHN+Q2icVkqk-CvUxTVh5cRkx2Jkn=pP=VtgKw@mail.gmail.com>
Date:   Mon, 15 May 2017 15:26:19 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Jean Delvare <jdelvare@...e.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Wei Yongjun <weiyongjun1@...wei.com>, bbaude@...hat.com,
        mildred-bug.kernel@...dred.fr, barnacs@...tletit.be,
        lvuksta@...il.com, lkml <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 3/3] pinctrl: cherryview: Extend the Chromebook DMI quirk
 to Intel_Strago systems

On Mon, May 15, 2017 at 4:14 AM, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> On Mon, 2017-05-15 at 14:01 +0300, Mika Westerberg wrote:
>> It turns out there are quite many Chromebooks out there that have the
>> same keyboard issue than Acer Chromebook. All of them are based on
>> Intel_Strago reference and report their DMI_PRODUCT_FAMILY as
>> "Intel_Strago" (Samsung Chromebook 3 and Cyan Chromebooks are
>> exceptions
>> for which we add separate entries).
>>
>> Instead of adding each machine to the quirk table, we use
>> DMI_PRODUCT_FAMILY of "Intel_Strago" that hopefully covers most of the
>> machines out there currently.
>>
>>
>
>> +             .ident = "Intel_Strago based Chromebooks",
>
>> +             .ident = "Cyan Chromebook",
>
>> +             .ident = "Samsung Chromebook 3",
>
> I would do something like below (though I'm fine with current as well).
>
>         .ident = "Intel_Strago based Chromebooks (All models)",
>         .ident = "Intel_Strago based Chromebooks (Cyan)",

I think this one should be "Acer Chromebook R11 (Cyan)"

Thanks.

-- 
Dmitry