linux-kernel - Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 May 2017 15:55:17 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times

El Sun, May 14, 2017 at 07:16:52PM +0900 Mark Brown ha dit:

> On Mon, May 01, 2017 at 11:37:15AM -0700, Matthias Kaehlcke wrote:
> 
> >  	else if (rdev->constraints->settling_time)
> >  		return rdev->constraints->settling_time;
> > +	else if (rdev->constraints->settling_time_up &&
> > +		 (new_uV > old_uV))
> > +		return rdev->constraints->settling_time_up;
> > +	else if (rdev->constraints->settling_time_down &&
> > +		 (new_uV < old_uV))
> > +		return rdev->constraints->settling_time_down;
> 
> It feels like we should warn if the user mixes specific up/down settling
> times with the more general property, can you please send a followup
> patch adding a warning for that?  It's not exactly obvious what the
> precedence is and may do the wrong thing with an older kernel or
> non-Linux OS.

Sounds good. I'll send out the patch soon.

Thanks

Matthias