linux-kernel - Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170516064116.GA30503@kroah.com>
Date:   Tue, 16 May 2017 08:41:16 +0200
From:   Greg KH <greg@...ah.com>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Raveendra Padasalagi <raveendra.padasalagi@...adcom.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Scott Branden <sbranden@...adcom.com>,
        linux-iio@...r.kernel.org, Ray Jui <rjui@...adcom.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Pavel Roskin <plroskin@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Hartmut Knaack <knaack.h@....de>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and
 secondary isr handler's

On Tue, May 16, 2017 at 09:08:27AM +0300, Baruch Siach wrote:
> Hi Greg,
> 
> On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> > On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > > The third argument of devm_request_threaded_irq() is the primary
> > > handler. It is called in hardirq context and checks whether the
> > > interrupt is relevant to the device. If the primary handler returns
> > > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > > scheduled to run in process context.
> > > 
> > > bcm_iproc_adc.c uses the secondary handler as the primary one
> > > and the other way around. So this patch fixes the same, along with
> > > re-naming the secondary handler and primary handler names properly.
> > > 
> > > Tested on the BCM9583XX iProc SoC based boards.
> > > 
> > > Reported-by: Pavel Roskin <plroskin@...il.com>
> > > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@...adcom.com>
> > > ---
> > >  drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > <formletter>
> > 
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
> 
> File moved to Documentation/process/stable-kernel-rules.rst since v4.10.
> 
> Maybe linking to 
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would 
> be better.

Ah, good point, I've updated my formletter now, thanks for this.

greg k-h