linux-kernel - Re: [PATCH v2] kbuild: skip install/check of headers right under uapi directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05860fa0-2186-8e02-5733-0f7528d9262f@6wind.com>
Date:   Tue, 16 May 2017 09:40:40 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kbuild@...r.kernel.org
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Michal Marek <mmarek@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: skip install/check of headers right under uapi
 directories

Le 16/05/2017 à 07:15, Masahiro Yamada a écrit :
> Since commit 61562f981e92 ("uapi: export all arch specifics
> directories"), "make INSTALL_HDR_PATH=$root/usr headers_install"
> deletes standard glibc headers and others in $root/usr/include.
> 
> The cause of the issue is that headers_install now starts descending
> from arch/$(hdr-arch)/include/uapi with $root/usr/include for its
> destination when installing asm headers.  So, headers already there
> are assumed to be unwanted.
> 
> When headers_install starts descending from include/uapi with
> $root/usr/include for its destination, it works around the problem
> by creating an dummy destination $root/usr/include/uapi, but this
> is tricky.
> 
> To fix the problem in a clean way is to skip headers install/check
> in include/uapi or arch/$(hdr-arch)/include/uapi because we know
> there are only sub-directories in uapi directories.  A good side
> effect is the empty destination $root/usr/include/uapi will go
> away.
> 
> I am also removing the trailing slash in the headers_check target to
> skip checking in arch/$(hdr-arch)/include/uapi.
> 
> Fixes: 61562f981e92 ("uapi: export all arch specifics directories")
> Reported-by: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
Thank you for the patch.

Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>