linux-kernel - Re: [PATCH RESEND 1/1] sched/rt: minimize rq->lock contention in, do_sched_rt_period

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170516081453.titdkpplakvhzydw@hirez.programming.kicks-ass.net>
Date:   Tue, 16 May 2017 10:14:53 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Dave Kleikamp <dave.kleikamp@...cle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH RESEND 1/1] sched/rt: minimize rq->lock contention in,
 do_sched_rt_period_timer()

On Mon, May 15, 2017 at 02:14:13PM -0500, Dave Kleikamp wrote:
> With CONFIG_RT_GROUP_SCHED defined, do_sched_rt_period_timer() sequentially
> takes each cpu's rq->lock. On a large, busy system, the cumulative time it
> takes to acquire each lock can be excessive, even triggering a watchdog
> timeout.
> 
> If rt_rq_rt_time and rt_rq->rt_nr_running are both zero, this function does
> nothing while holding the lock, so don't bother taking it at all.

Indeed, thanks Dave!