linux-kernel - Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170516081638.xg34g52xpvlkpqfg@piout.net>
Date:   Tue, 16 May 2017 10:16:38 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Moritz Fischer <mdf@...nel.org>
Cc:     Rob Herring <robh@...nel.org>, linux-watchdog@...r.kernel.org,
        rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
        lee.jones@...aro.org, devicetree@...r.kernel.org,
        linux@...ck-us.net, wim@...ana.be, a.zummo@...ertech.it,
        mark.rutland@....com
Subject: Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD
 device binding

On 15/05/2017 at 19:34:17 -0700, Moritz Fischer wrote:
> On Fri, May 12, 2017 at 07:00:29PM -0500, Rob Herring wrote:
> > On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote:
> > > +			<0> for RTC
> > > +			<1> for RTC + Alarm (Interrupt)
> > > +			<2> for RTC + Watchdog
> > > +
> > > +Required child:
> > > +A single available child device of type matching the "dallas,ds1374-mode"
> > > +property.
> > > +
> > > +Optional properties (watchdog):
> > > +- dallas,ds1374-remap-wdt-reset: Boolean describing whether the INT pin
> > > +				 on the device is used as interrupt for
> > > +				 the alarm
> > 
> > Isn't presence of the interrupt property or not enough? It would be 
> > kind of useless to have no interrupt and also not do anything on 
> > timeout.
> 
> So you're saying:
> 
> If interrupt not present AND mode = <0> ignore interrupt
> 
> If interrupt present AND mode = <1> (maybe define here would be nicer),
> make it an interrupt.
> 

If mode == 1, WDSTR doesn't matter so it will always be on the INT pin
anyway.

> If interrupt not present AND mode = <2> then this implies that reset
> output is mapped to RST pin.
> 
> If Interrupt present AND mode = <2> then this implies that the reset
> output is (re)mapped to INT pin?
> 

Yes, I think this is sufficient.



-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com