[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAALAos8W72yntS746Q2JE_6qwSBJV65acwapUR_3H7nf6skcFQ@mail.gmail.com>
Date: Tue, 16 May 2017 16:17:58 +0530
From: Anup Patel <anup.patel@...adcom.com>
To: Mark Rutland <mark.rutland@....com>
Cc: Rob Herring <robh+dt@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>, Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
Jon Mason <jonmason@...adcom.com>,
Florian Fainelli <f.fainelli@...il.com>,
Oza Pawandeep <oza.oza@...adcom.com>,
Srinath Mannam <srinath.mannam@...adcom.com>,
Pramod Kumar <pramod.kumar@...adcom.com>,
Sandeep Tripathy <sandeep.tripathy@...adcom.com>,
Device Tree <devicetree@...r.kernel.org>,
Linux Kernel <linux-kernel@...r.kernel.org>,
linux-clk@...r.kernel.org,
Linux ARM Kernel <linux-arm-kernel@...ts.infradead.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
Scott Branden <scott.branden@...adcom.com>
Subject: Re: [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom
Stingray SOC
On Mon, May 15, 2017 at 6:43 PM, Mark Rutland <mark.rutland@....com> wrote:
> Hi,
>
> On Mon, May 15, 2017 at 05:32:14PM +0530, Anup Patel wrote:
>> +/ {
>> + chosen { /* Default kernel args */
>> + bootargs = "root=/dev/ram rw rootwait \
>> + earlycon=uart8250,mmio32,0x68a10000 \
>> + pci=pcie_bus_safe cma=64M";
>
> Why do we need all of these?
Yes, we don't need bootargs here. This were just for reference.
I will remove default bootargs because its responsibility of
bootloader to add it.
>
>> + linux,stdout-path = "serial0:115200n8";
>
> Please drop the 'linux,' prefix here.
Sure, will do.
>
> [...]
>
>> + memory: memory@...00000 {
>> + device_type = "memory";
>> + reg = <0x00000000 0x80000000 0 0x40000000>;
>> + };
>> +
>> + psci {
>> + compatible = "arm,psci-0.2";
>> + method = "smc";
>> + };
>> +
>> + pmu {
>> + compatible = "arm,armv8-pmuv3";
>> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>> + timer {
>> + compatible = "arm,armv8-timer";
>> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) |
>> + IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) |
>> + IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) |
>> + IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) |
>> + IRQ_TYPE_LEVEL_LOW)>;
>
> GICv3 PPIs don't have a mask. See
>
> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
>
> Please remove the GIC_CPU_MASK_*() uses here and in this dts. They
> shouldn't be there.
Thanks for catching.
We had taken care of this in PMU DT node but did not cleanup timer
DT node.
Thanks,
Anup
Powered by blists - more mailing lists