linux-kernel - Re: [PATCH] scripts: check.c fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+K8wN_OjoePoZCd-xXcAKfO22sBLj6SjoEqxZ+aDwyOg@mail.gmail.com>
Date:   Tue, 16 May 2017 07:52:54 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Shuah Khan <shuahkh@....samsung.com>
Cc:     Frank Rowand <frowand.list@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts: check.c fix compile error

On Mon, May 15, 2017 at 2:10 PM, Shuah Khan <shuahkh@....samsung.com> wrote:
> Fix the following compile error:

On what host? 32-bit I guess.

I'll take this, but can you also send this to upstream dtc and
devicetree-compiler list. Normally, dtc is just an import.

>
> checks.c: In function ‘check_simple_bus_reg’:
> checks.c:876:41: error: format ‘%lx’ expects argument of type
> ‘long unsigned int’, but argument 4 has type ‘uint64_t {aka
> long long unsigned int}’ [-Werror=format=]
>   snprintf(unit_addr, sizeof(unit_addr), "%lx", reg);
>                                          ^
> checks.c:876:41: error: format ‘%lx’ expects argument of type
> ‘long unsigned int’, but argument 4 has type ‘uint64_t
> {aka long long unsigned int}’ [-Werror=format=]
> cc1: all warnings being treated as errors
> Makefile:304: recipe for target 'checks.o' failed
> make: *** [checks.o] Error 1
>
> Signed-off-by: Shuah Khan <shuahkh@....samsung.com>
> ---
>  scripts/dtc/checks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/dtc/checks.c b/scripts/dtc/checks.c
> index 5adfc8f..6dfb82f 100644
> --- a/scripts/dtc/checks.c
> +++ b/scripts/dtc/checks.c
> @@ -873,7 +873,7 @@ static void check_simple_bus_reg(struct check *c, struct dt_info *dti, struct no
>         while (size--)
>                 reg = (reg << 32) | fdt32_to_cpu(*(cells++));
>
> -       snprintf(unit_addr, sizeof(unit_addr), "%lx", reg);
> +       snprintf(unit_addr, sizeof(unit_addr), "%llx", reg);
>         if (!streq(unitname, unit_addr))
>                 FAIL(c, dti, "Node %s simple-bus unit address format error, expected \"%s\"",
>                      node->fullpath, unit_addr);
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html