linux-kernel - Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170516134515.GG22219@n2100.armlinux.org.uk>
Date:   Tue, 16 May 2017 14:45:15 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Marcin Wojtas <mw@...ihalf.com>
Cc:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Andrew Lunn <andrew@...n.ch>,
        Jason Cooper <jason@...edaemon.net>,
        "jaz@...ihalf.com" <jaz@...ihalf.com>,
        Will Deacon <will.deacon@....com>,
        linux-kernel@...r.kernel.org, nadavh@...vell.com,
        Rob Herring <robh+dt@...nel.org>,
        Neta Zur Hershkovits <neta@...vell.com>,
        Tomasz Nowicki <tn@...ihalf.com>,
        Gregory Clément 
        <gregory.clement@...e-electrons.com>,
        Mark Rutland <mark.rutland@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH 1/2] arm64: marvell: dts: fill MachiatoBin board
 description

On Tue, May 16, 2017 at 02:44:48PM +0200, Marcin Wojtas wrote:
> Russel,
> 
> 2017-05-16 14:13 GMT+02:00 Russell King - ARM Linux <linux@...linux.org.uk>:
> > On Tue, May 16, 2017 at 01:52:17PM +0200, Thomas Petazzoni wrote:
> >> Hello,
> >>
> >> On Tue, 16 May 2017 11:02:37 +0100, Russell King - ARM Linux wrote:
> >>
> >> > > Correct, but Marcin has submitted patches, and you haven't.
> >> >
> >> > As I said, give me a friggin chance.  You know full well that I've been
> >> > working on this, working with you and submitting patches.
> >>
> >> Correct. But Marcin patches are small and easy, they are ready today,
> >> and they bring useful benefits for users. You're trying to provide a
> >> full blown solution, which ultimately is good, but in the mean time it
> >> would be good to enable the features that already work today.
> >
> > Unfortunately, they don't all work - see my other email.  The SD slot
> > is non-functional with the latest sdhci-xenon driver.  The previous
> > revision worked fine.
> >
> >> > > I believe if you say that, it's because you don't know how much work
> >> > > Marcin is doing behind the scenes on supporting Marvell platforms, and
> >> > > not only at the Linux kernel level.
> >> >
> >> > Maybe Marcin doesn't know how much work I'm doing supporting this board?
> >>
> >> Marcin also knows you're doing some work on this board.
> >
> > Right, so this is all one way.  It would have been nice to have had a
> > heads-up or something, which would have aided co-operation instead of
> > confrontation.
> >
> >> > It _has_ been submitted - a few months ago - so you're talking rubbish
> >> > here.  You just need to check your mailbox.
> >>
> >> Could you please avoid insults? It doesn't bring any benefit.
> >>
> >> And in addition, you're deforming reality. The reality is:
> >>
> >>  - The patches you posted are related to pinmux/gpio support. This is
> >>    one thing.
> >
> > The point you replied to was about pinmux/gpio, not about Marcin's patch.
> > So you trying to twist this back to Marcin's patches is unhelpful.
> > Stop being a problem.
> >
> >> Therefore, there is no reason to not merge Marcin patches, because they
> >> do not conflict with anything you have already posted.
> >
> > Except that the SD slot is broken.
> >
> 
> Rechecked, on my board - copied 100MB file back and forth to and from
> SD card and it works properly, so indeed that may be some regression
> in the latest version of the driver, but apparently not for all cards.

It doesn't seem to be "not for all cards" - if I boot without a card in
the slot, I still get the kernel message spew.  Turns out to be a merge
error, which I hadn't realised due to the pressure of this thread.

However, since I have a patch which adds SDHCI support with the comments
that Tom has against yours already fixed (which is a trivial subset of
my patch adding SDHCI with pinmux support) I'm about to send that.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.