linux-kernel - Re: [PATCH 17/17] fs: switch ->s_uuid to uuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170516155307.GA2086@lst.de>
Date:   Tue, 16 May 2017 17:53:07 +0200
From:   Christoph Hellwig <hch@....de>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     Christoph Hellwig <hch@....de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Shaohua Li <shli@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        David Howells <dhowells@...hat.com>,
        Steven Whitehouse <swhiteho@...hat.com>,
        Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        linux-xfs <linux-xfs@...r.kernel.org>,
        linux-raid@...r.kernel.org, linux-nvdimm@...ts.01.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 17/17] fs: switch ->s_uuid to uuid_t

On Mon, May 15, 2017 at 10:38:18PM +0300, Amir Goldstein wrote:
> On Mon, May 15, 2017 at 6:43 PM, Christoph Hellwig <hch@....de> wrote:
> > For some file systems we still memcpy into it, but in various places this
> > already allows us to use the proper uuid helpers.  More to come..
> >
> > Signed-off-by: Christoph Hellwig <hch@....de>
> > ---
> 
> > --- a/fs/xfs/xfs_mount.c
> > +++ b/fs/xfs/xfs_mount.c
> > @@ -75,7 +75,7 @@ xfs_uuid_mount(
> >
> >         /* Publish UUID in struct super_block */
> >         BUILD_BUG_ON(sizeof(mp->m_super->s_uuid) != sizeof(uuid_t));
> 
> BUILD_BUG_ON not needed anymore now that s_uuid is uuid_t

Yeah, you mentioned that last time and I forgot about it.  Fixed up
in the git tree and for the next repost.