linux-kernel - Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 May 2017 21:27:55 +0530
From:   srishti sharma <srishtishar@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Ian Abbott <abbotti@....co.uk>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Abc Abc <thrust73@...il.com>
Subject: Re: [PATCH] Staging: comedi: comedidev.h: fixed a warning

On Tue, May 16, 2017 at 2:45 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Tue, May 16, 2017 at 02:00:23PM +0530, srishti wrote:
>> Fixed a warning : struct comedi_lrange is generally constant.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@...il.com>
>
> As Dan pointed out, you _HAVE_ to test-build your changes.
>
> Also, your "From:" line didn't match your signed-off-by line, so I
> couldn't accept this anyway.
>
> thanks,
>
> greg k-h

Thanks for pointing out the error , but this patch is not needed as it
was for fixing a warning produced by checkpatch.pl that says struct
comedi_lrange is usually constant . But on building the code I get
another warning which says that the type qualifier is useless.

Regards,
Srishti