Message-ID: <5a4a5b58-3e31-9fa5-091d-bb63437da9ab@codeaurora.org>
Date:   Tue, 16 May 2017 10:44:43 -0600
From:   "Baicar, Tyler" <tbaicar@...eaurora.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     christoffer.dall@...aro.org, marc.zyngier@....com,
        pbonzini@...hat.com, rkrcmar@...hat.com, linux@...linux.org.uk,
        catalin.marinas@....com, will.deacon@....com, rjw@...ysocki.net,
        lenb@...nel.org, matt@...eblueprint.co.uk, robert.moore@...el.com,
        lv.zheng@...el.com, nkaje@...eaurora.org, zjzhang@...eaurora.org,
        mark.rutland@....com, james.morse@....com,
        akpm@...ux-foundation.org, eun.taik.lee@...sung.com,
        sandeepa.s.prabhu@...il.com, labbott@...hat.com,
        shijie.huang@....com, rruigrok@...eaurora.org,
        paul.gortmaker@...driver.com, tn@...ihalf.com, fu.wei@...aro.org,
        rostedt@...dmis.org, bristot@...hat.com,
        linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
        kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-efi@...r.kernel.org,
        Suzuki.Poulose@....com, punit.agrawal@....com, astone@...hat.com,
        harba@...eaurora.org, hanjun.guo@...aro.org, john.garry@...wei.com,
        shiju.jose@...wei.com, joe@...ches.com, rafael@...nel.org,
        tony.luck@...el.com, gengdongjiu@...wei.com, xiexiuqi@...wei.com
Subject: Re: [PATCH V16 08/11] efi: print unrecognized CPER section

On 5/16/2017 8:29 AM, Borislav Petkov wrote:
> On Mon, May 15, 2017 at 03:27:57PM -0600, Tyler Baicar wrote:
>> UEFI spec allows for non-standard section in Common Platform Error
>> Record. This is defined in section N.2.3 of UEFI version 2.5.
>>
>> Currently if the CPER section's type (UUID) does not match with
>> one of the section types that the kernel knows how to parse, the
>> section is skipped. Therefore, user is not able to see
>> such CPER data, for instance, error record of non-standard section.
>>
>> This change prints out the raw data in hex in the dmesg buffer so
>> that non-standard sections are reported to the user. Non-standard
>> section type errors should be reported to the user because these
>> can include errors which are vendor specific. The data length is
>> taken from Error Data length field of Generic Error Data Entry.
>>
>> The following is a sample output from dmesg:
>> [  140.739180] {1}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 2
>> [  140.739182] {1}[Hardware Error]: It has been corrected by h/w and requires no further action
>> [  140.739191] {1}[Hardware Error]: event severity: corrected
>> [  140.739196] {1}[Hardware Error]:  time: precise 2017-03-15 20:37:35
>> [  140.739197] {1}[Hardware Error]:  Error 0, type: corrected
>> [  140.739203] {1}[Hardware Error]:   section type: unknown, d2e2621c-f936-468d-0d84-15a4ed015c8b
>> [  140.739205] {1}[Hardware Error]:   section length: 0x238
>> [  140.739210] {1}[Hardware Error]:   00000000: 4d415201 4d492031 453a4d45 435f4343  .RAM1 IMEM:ECC_C
>> [  140.739214] {1}[Hardware Error]:   00000010: 53515f45 44525f42 00000000 00000000  E_QSB_RD........
>> [  140.739217] {1}[Hardware Error]:   00000020: 00000000 00000000 00000000 00000000  ................
>> [  140.739220] {1}[Hardware Error]:   00000030: 00000000 00000000 01010000 01010000  ................
>> [  140.739223] {1}[Hardware Error]:   00000040: 00000000 00000000 00000005 00000000  ................
>> [  140.739226] {1}[Hardware Error]:   00000050: 01010000 00000000 00000001 00dddd00  ................
> Let me repeat myself from the last time:
>
> "Kill all those prefixes:
>
> " Hardware error from APEI Generic Hardware Error Source: 2
>    It has been corrected by h/w and requires no further action
>    event severity: corrected
>     time: precise 2017-03-15 20:37:35
>     Error 0, type: corrected
>      section type: unknown, d2e2621c-f936-468d-0d84-15a4ed015c8b
>      section length: 568 (0x238)
>      00000000: 4d415201 4d492031 453a4d45 435f4343  .RAM1 IMEM:ECC_C
>      00000010: 53515f45 44525f42 00000000 00000000  E_QSB_RD........
>      00000020: 00000000 00000000 00000000 00000000  ................
>      00000030: 00000000 00000000 01010000 01010000  ................
>      00000040: 00000000 00000000 00000005 00000000  ................
>      00000050: 01010000 00000000 00000001 00dddd00  ................
> "
>
> to the important info only."
Hello Boris,

I meant to respond to this comment after I sent the v16 patch series, 
but you beat me to it :)

These prefixes are common to all the GHES/CPER printing to the kernel 
logs. The first value here '{1}' is an increment based on the number of 
error records that have been printed during the current boot. This value 
can be very helpful when trying to parse the log which could have 
hundreds or thousands of these errors. Just yesterday I saw a log with 
~250 records printed. It was a lot easier to see that incremented number 
and know how many were in the log than to actually parse the log to 
count that information.

The '[Hardware Error]' print I could see doing away with, but it does 
actually have value when you're looking through the logs. It helps these 
errors stand out especially to people who aren't looking for them. These 
hardware errors shouldn't be happening, so it makes sense for them to 
stand out in the logs. And it also helps to find all these records in a 
log that could be littered with a lot of other prints. I find myself 
doing "dmesg | grep 'Hardware error'" all the time.

Hopefully that is enough justification to keep these. If not, then I can 
add a separate patch in this series to remove them.

Thanks,
Tyler

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.

Powered by blists - more mailing lists