linux-kernel - Re: [PATCH v2 04/53] mutex, futex: adjust kernel-doc markups to generate ReST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170516190009.GA29495@fury>
Date:   Tue, 16 May 2017 12:00:09 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Mauro Carvalho Chehab <mchehab@...pensource.com>
Cc:     Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...radead.org>,
        linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        linux-mtd@...ts.infradead.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2 04/53] mutex, futex: adjust kernel-doc markups to
 generate ReST

On Tue, May 16, 2017 at 03:24:18PM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 16 May 2017 10:35:40 -0700
> Darren Hart <dvhart@...radead.org> escreveu:
> 
> > On Tue, May 16, 2017 at 09:15:56AM -0300, Mauro Carvalho Chehab wrote:
> > > There are a few issues on some kernel-doc markups that was
> > > causing troubles with kernel-doc output on ReST format:
> > > 
> > > ./kernel/futex.c:492: WARNING: Inline emphasis start-string without end-string.
> > > ./kernel/futex.c:1264: WARNING: Block quote ends without a blank line; unexpected unindent.
> > > ./kernel/futex.c:1721: WARNING: Block quote ends without a blank line; unexpected unindent.
> > > ./kernel/futex.c:2338: WARNING: Block quote ends without a blank line; unexpected unindent.
> > > ./kernel/futex.c:2426: WARNING: Block quote ends without a blank line; unexpected unindent.
> > > ./kernel/futex.c:2899: WARNING: Block quote ends without a blank line; unexpected unindent.
> > > ./kernel/futex.c:2972: WARNING: Block quote ends without a blank line; unexpected unindent.
> > > 
> > > Fix them.
> > > 
> > > No functional changes.
> > > 
> > > Acked-by: Darren Hart (VMware) <dvhart@...radead.org>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@...pensource.com>
> > > ---  
> > 
> > 
> > What was the difference from v1? Quick scan didn't reveal anything obvious to
> > me... (context left intact in case you want to point it out inline), but just a
> > "Changes since v1" below the --- is always appreciated - even it it's "no
> > changes, new commit log".
> 
> From v1, the .. note:: got removed. That's pretty much the same version
> found on one of my replies + the addition of the warnings it produces
> without the patch.

Thanks Mauro. This still seems reasonable to me.

-- 
Darren Hart
VMware Open Source Technology Center