| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 May 2017 11:55:38 +0800
From: kbuild test robot <lkp@...el.com>
To: Al Viro <viro@...IV.linux.org.uk>
Cc: kbuild-all@...org, linux-kernel@...r.kernel.org,
Linus Torvalds <torvalds@...ux-foundation.org>,
Ingo Molnar <mingo@...nel.org>,
Oleg Nesterov <oleg@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 8/8] waitid(): switch copyout of siginfo to
unsafe_put_user()
Hi Al,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.12-rc1 next-20170515]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Al-Viro/move-compat-wait4-and-waitid-next-to-native-variants/20170516-084127
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc
All warnings (new ones prefixed by >>):
In file included from include/asm-generic/bug.h:4:0,
from arch/powerpc/include/asm/bug.h:127,
from include/linux/bug.h:4,
from include/linux/mmdebug.h:4,
from include/linux/mm.h:8,
from kernel/exit.c:7:
kernel/exit.c: In function 'C_SYSC_waitid':
kernel/exit.c:1746:38: error: 'infop' undeclared (first use in this function)
unsafe_put_user(err ? 0 : SIGCHLD, &infop->si_signo, Efault);
^
include/linux/compiler.h:179:42: note: in definition of macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
>> arch/powerpc/include/asm/uaccess.h:86:2: note: in expansion of macro '__put_user_nocheck'
__put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
^~~~~~~~~~~~~~~~~~
include/linux/uaccess.h:302:56: note: in expansion of macro '__put_user'
#define unsafe_put_user(x, ptr, err) do { if (unlikely(__put_user(x, ptr))) goto err; } while (0)
^~~~~~~~~~
kernel/exit.c:1746:2: note: in expansion of macro 'unsafe_put_user'
unsafe_put_user(err ? 0 : SIGCHLD, &infop->si_signo, Efault);
^~~~~~~~~~~~~~~
kernel/exit.c:1746:38: note: each undeclared identifier is reported only once for each function it appears in
unsafe_put_user(err ? 0 : SIGCHLD, &infop->si_signo, Efault);
^
include/linux/compiler.h:179:42: note: in definition of macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
>> arch/powerpc/include/asm/uaccess.h:86:2: note: in expansion of macro '__put_user_nocheck'
__put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
^~~~~~~~~~~~~~~~~~
include/linux/uaccess.h:302:56: note: in expansion of macro '__put_user'
#define unsafe_put_user(x, ptr, err) do { if (unlikely(__put_user(x, ptr))) goto err; } while (0)
^~~~~~~~~~
kernel/exit.c:1746:2: note: in expansion of macro 'unsafe_put_user'
unsafe_put_user(err ? 0 : SIGCHLD, &infop->si_signo, Efault);
^~~~~~~~~~~~~~~
vim +/__put_user_nocheck +86 arch/powerpc/include/asm/uaccess.h
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 70 * with a separate "access_ok()" call (this is used when we do multiple
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 71 * accesses to the same area of user memory).
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 72 *
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 73 * As we use the same address space for kernel and user data on the
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 74 * PowerPC, we can just do these as direct assignments. (Of course, the
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 75 * exception handling means that it's no longer "just"...)
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 76 *
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 77 */
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 78 #define get_user(x, ptr) \
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 79 __get_user_check((x), (ptr), sizeof(*(ptr)))
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 80 #define put_user(x, ptr) \
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 81 __put_user_check((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 82
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 83 #define __get_user(x, ptr) \
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 84 __get_user_nocheck((x), (ptr), sizeof(*(ptr)))
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 85 #define __put_user(x, ptr) \
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 @86 __put_user_nocheck((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 87
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 88 #define __get_user_inatomic(x, ptr) \
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 89 __get_user_nosleep((x), (ptr), sizeof(*(ptr)))
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 90 #define __put_user_inatomic(x, ptr) \
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 91 __put_user_nosleep((__typeof__(*(ptr)))(x), (ptr), sizeof(*(ptr)))
e68c825b include/asm-powerpc/uaccess.h Benjamin Herrenschmidt 2007-04-11 92
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 93 #define __get_user_unaligned __get_user
2df5e8bc include/asm-powerpc/uaccess.h Stephen Rothwell 2005-10-29 94 #define __put_user_unaligned __put_user
:::::: The code at line 86 was first introduced by commit
:::::: 2df5e8bcca53e528a78ee0e3b114d0d21dd6d043 powerpc: merge uaccess.h
:::::: TO: Stephen Rothwell <sfr@...b.auug.org.au>
:::::: CC: Stephen Rothwell <sfr@...b.auug.org.au>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (53757 bytes)
Powered by blists - more mailing lists