linux-kernel - Re: [PATCH] staging: media: cxd2099: Fix checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82946e90-46a5-de5a-40db-adeaa4839976@anw.at>
Date:   Tue, 16 May 2017 22:47:48 +0200
From:   "Jasmin J." <jasmin@....at>
To:     eddi1983 <eddi1983@....net>, mchehab@...nel.org
Cc:     gregkh@...uxfoundation.org, diaconitatamara@...il.com,
        daniel.baluta@...il.com, eraretuya@...il.com,
        elise.lennion@...il.com, linux-media@...r.kernel.org,
        0devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: cxd2099: Fix checkpatch issues

Hello Christoph!

The current cxd2099 driver is an old version. DD provides a newer variant.
Please see my patch series
   http://www.mail-archive.com/linux-media@vger.kernel.org/msg112410.html
Especially this patch
   http://www.mail-archive.com/linux-media@vger.kernel.org/msg112409.html
where I remove this useless printing already.

I kept the "slot_shutdown" print in my series, because it is useful and called
only if someone removes the CAM, but I removed all the other useless ones.

So I can agree with your first hunk.

It would be better to wait with this change after my series is approved!

BR,
    Jasmin