linux-kernel - Re: [PATCH] nvmem: core: fix leaks on registration errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqE6S8McfPGYa=zfbnC5WY4CTqucbuFXYt6zrMwZiZBiFg@mail.gmail.com>
Date:   Tue, 16 May 2017 14:28:28 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH] nvmem: core: fix leaks on registration errors

On Tue, May 16, 2017 at 6:44 AM, Johan Hovold <johan@...nel.org> wrote:
> Make sure to deregister and release the nvmem device and underlying
> memory on registration errors.
>
> Note that the private data must be freed using put_device() once the
> struct device has been initialised.
>
> Also note that there's a related reference leak in the deregistration
> function as reported by Mika Westerberg which is being fixed separately.
>
> Fixes: b6c217ab9be6 ("nvmem: Add backwards compatibility support for older EEPROM drivers.")
> Fixes: eace75cfdcf7 ("nvmem: Add a simple NVMEM framework for nvmem providers")
> Cc: stable <stable@...r.kernel.org>     # 4.3
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---

I submitted identical patch to fix this about a month ago here:

lkml.kernel.org/r/20170418142454.23921-1-andrew.smirnov@...il.com

so, FWIW,

Acked-by: Andrey Smirnov <andrew.smirnov@...il.com>

>  drivers/nvmem/core.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 8c830a80a648..6cf916d9db6d 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -489,21 +489,24 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
>
>         rval = device_add(&nvmem->dev);
>         if (rval)
> -               goto out;
> +               goto err_put_device;
>
>         if (config->compat) {
>                 rval = nvmem_setup_compat(nvmem, config);
>                 if (rval)
> -                       goto out;
> +                       goto err_device_del;
>         }
>
>         if (config->cells)
>                 nvmem_add_cells(nvmem, config);
>
>         return nvmem;
> -out:
> -       ida_simple_remove(&nvmem_ida, nvmem->id);
> -       kfree(nvmem);
> +
> +err_device_del:
> +       device_del(&nvmem->dev);
> +err_put_device:
> +       put_device(&nvmem->dev);
> +
>         return ERR_PTR(rval);
>  }
>  EXPORT_SYMBOL_GPL(nvmem_register);
> --
> 2.13.0
>