linux-kernel - Re: [PATCH V1] i2c: xgene: Add support for I2C_FUNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170516213640.2t57hdumkzxcdw5o@ninjato>
Date:   Tue, 16 May 2017 23:36:41 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     tnhuynh@....com
Cc:     linux-i2c@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Loc Ho <lho@....com>,
        Phong Vo <pvo@....com>, patches@....com
Subject: Re: [PATCH V1] i2c: xgene: Add support for I2C_FUNC_I2C functionality

On Wed, Apr 26, 2017 at 11:41:45AM +0700, tnhuynh@....com wrote:
> From: Tin Huynh <tnhuynh@....com>
> 
> Certain I2C slave drivers, such as the pca95xx, require
> only I2C operations instead of SMBus extensions.
> This patch adds I2C_FUNC_I2C functionally to support those drivers.

No Signed-off, please run checkpatch on your patches!

> -	return I2C_FUNC_SMBUS_BYTE |
> +	return I2C_FUNC_I2C |
> +		I2C_FUNC_SMBUS_BYTE |

Does this really work? You don't have a master_xfer function, so I think
it cannot work. You don't seem to have I2C_FUNC_I2C support in your driver.

>  		I2C_FUNC_SMBUS_BYTE_DATA |
>  		I2C_FUNC_SMBUS_WORD_DATA |
>  		I2C_FUNC_SMBUS_BLOCK_DATA |
> -- 
> 1.7.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)