[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170516224107.GD113464@gmail.com>
Date: Tue, 16 May 2017 15:41:07 -0700
From: Eric Biggers <ebiggers3@...il.com>
To: Gilad Ben-Yossef <gilad@...yossef.com>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Jonathan Corbet <corbet@....net>,
David Howells <dhowells@...hat.com>,
Ofir Drang <ofir.drang@....com>,
Gilad Ben-Yossef <gilad.benyossef@....com>,
linux-crypto@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, keyrings@...r.kernel.org
Subject: Re: [PATCH 4/4] crypto: Documentation: fix none signal safe sample
On Thu, May 11, 2017 at 02:53:45PM +0300, Gilad Ben-Yossef wrote:
> The sample code was showing use of wait_for_completion_interruptible()
> for waiting for an async. crypto op to finish. However, if a signal
> arrived it would free the buffers used even while crypto HW might
> still DMA from/into the buffers.
>
> Resolve this by using wait_for_completion() instead.
>
> Reported-by: Eric Biggers <ebiggers3@...il.com>
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> ---
> Documentation/crypto/api-samples.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/crypto/api-samples.rst b/Documentation/crypto/api-samples.rst
> index d021fd9..944f08b 100644
> --- a/Documentation/crypto/api-samples.rst
> +++ b/Documentation/crypto/api-samples.rst
> @@ -48,7 +48,7 @@ Code Example For Symmetric Key Cipher Operation
> break;
> case -EINPROGRESS:
> case -EBUSY:
> - rc = wait_for_completion_interruptible(
> + rc = wait_for_completion(
> &sk->result.completion);
> if (!rc && !sk->result.err) {
> reinit_completion(&sk->result.completion);
> --
> 2.1.4
>
Same issue here: wait_for_completion() doesn't return a value.
Eric
Powered by blists - more mailing lists