linux-kernel - Re: [PATCH] kbuild: skip header install/check for right under uapi directories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4j_zRJvTkqCgaG9+dEsvvitsz_TZB=bS8eWS+=2mGysXQ@mail.gmail.com>
Date:   Mon, 15 May 2017 22:03:11 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-kbuild@...r.kernel.org,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>,
        Michal Marek <mmarek@...e.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: skip header install/check for right under uapi directories

On Mon, May 15, 2017 at 9:35 PM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> Since commit 61562f981e92 ("uapi: export all arch specifics
> directories"), "make INSTALL_HDR_PATH=${root}/usr headers_install"
> deletes standard glibc headers and others in ${root}/usr/include.
>
> The cause of the issue is that headers_install now starts descending
> from arch/$(hdr-arch)/include/uapi with ${root}/usr/include for its
> destination when installing asm headers.  So, headers already there
> are assumed to be unwanted.
>
> When headers_install starts descending from include/uapi with
> ${root}/usr/include for its destination, it works around the problem
> by creating an dummy destination ${root}/usr/include/uapi, but this
> is tricky.
>
> To fix the problem in a clean way is to skip header install/check in
> include/uapi or arch/$(hdr-arch)/include/uapi.  A good side-effect
> is the empty destination ${root}/usr/include/uapi will go away.
>
> Fixes: 61562f981e92 ("uapi: export all arch specifics directories")
> Reported-by: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Works for me.

Tested-by: Dan Williams <dan.j.williams@...el.com>