linux-kernel - Re: [PATCH 1/2] ubifs: Fix inode data budget in ubifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12b604d9-22e9-f0e5-288a-e478d2ba4e4f@nod.at>
Date:   Wed, 17 May 2017 08:58:23 +0200
From:   Richard Weinberger <richard@....at>
To:     Hyunchul Lee <cheol.lee@....com>
Cc:     Artem Bityutskiy <dedekind1@...il.com>, adrian.hunter@...el.com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-mtd@...ts.infradead.org, kernel-team@....com
Subject: Re: [PATCH 1/2] ubifs: Fix inode data budget in ubifs_mknod

Hyunchul,

Am 17.05.2017 um 01:57 schrieb Hyunchul Lee:
> Assign inode data budget to budget request correctly.
> 
> Signed-off-by: Hyunchul Lee <cheol.lee@....com>
> ---
>  fs/ubifs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
> index b777bdd..df67236 100644
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -1050,7 +1050,6 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
>  	int sz_change;
>  	int err, devlen = 0;
>  	struct ubifs_budget_req req = { .new_ino = 1, .new_dent = 1,
> -					.new_ino_d = ALIGN(devlen, 8),
>  					.dirtied_ino = 1 };
>  	struct fscrypt_name nm;
>  
> @@ -1068,6 +1067,7 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
>  		devlen = ubifs_encode_dev(dev, rdev);
>  	}
>  
> +	req.new_ino_d = ALIGN(devlen, 8);

Good find!

Thanks,
//richard