linux-kernel - Re: [PATCH] perf report: Fix invalid warning on callchain param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8594997.vKN7rfjkqZ@milian-kdab2>
Date:   Wed, 17 May 2017 10:17:02 +0200
From:   Milian Wolff <milian.wolff@...b.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@....com,
        Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] perf report: Fix invalid warning on callchain param

On Wednesday, May 17, 2017 9:08:37 AM CEST Namhyung Kim wrote:
> Currently "perf report -g srcline --stdio" shows two warnings like
> below:
> 
>   Invalid callchain mode: srcline
>   Invalid callchain order: srcline
> 
> This is because it always tries to parse callchain mode, order, sort-key
> and value-type in a row.  So even if 'srcline' is a valid sort-key, it
> shows invalid mode and order warnings.
> 
> Change it to show a warning only if failed to parse the given token as
> any of valid parameter.  Also code under try_numbers requires the token
> to be a number, it's good to show the warning there.
> 
> Cc: Milian Wolff <milian.wolff@...b.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>

Thank you, that annoyed me too. Tested and reviewed it, works fine - thanks!

Bye

-- 
Milian Wolff | milian.wolff@...b.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
Download attachment "smime.p7s" of type "application/pkcs7-signature" (5903 bytes)