linux-kernel - Re: [PATCH] seq_file: delete small-value optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 May 2017 13:33:41 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     joe@...ches.com
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] seq_file: delete small-value optimization

> Joe Perches wrote:
> 
> On Tue, 2017-05-16 at 23:42 +0300, Alexey Dobriyan wrote:
> > num_to_str() optimizes printing small integers [0..9], so the same
> > check higher in callchain is unnecessary.
> 
> Doesn't the optimization exists for the frequent use of 0
> in seq output?  
> 
> These seq_put_decimal calls are now slightly more expensive.

That additional CALL instruction is hardly measurable so you're adding
branch to skip branch in the next function.