lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 17 May 2017 14:20:54 +0200 From: Takashi Iwai <tiwai@...e.de> To: "Bhumika Goyal" <bhumirks@...il.com> Cc: <alsa-devel@...a-project.org>, <julia.lawall@...6.fr>, <perex@...ex.cz>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures On Wed, 17 May 2017 13:38:56 +0200, Bhumika Goyal wrote: > > Declare snd_kcontrol_new structures as const as they are only passed an > argument to the function snd_ctl_new1. This argument is of type const, > so snd_kcontrol_new structures having this property can be made const. > Done using Coccinelle: > > @r disable optional_qualifier@ > identifier x; > position p; > @@ > static struct snd_kcontrol_new x@......}; > > @ok@ > identifier r.x; > position p; > @@ > snd_ctl_new1(&x@p,...) > > @bad@ > position p != {r.p,ok.p}; > identifier r.x; > @@ > x@p > > @depends on !bad disable optional_qualifier@ > identifier r.x; > @@ > +const > struct snd_kcontrol_new x; > > Signed-off-by: Bhumika Goyal <bhumirks@...il.com> As I already asked, could you send as a patchset if you have multiple similar patches? thanks, Takashi
Powered by blists - more mailing lists