linux-kernel - Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33877b30-e903-c0ce-37d7-ec344a03da58@ginzinger.com>
Date:   Wed, 17 May 2017 14:39:16 +0200
From:   Martin Kepplinger <martin.kepplinger@...zinger.com>
To:     Rob Herring <robh@...nel.org>, <dmitry.torokhov@...il.com>
CC:     <simon.budig@...nelconcepts.de>,
        <daniel.wagener@...nelconcepts.de>, <mchehab@...nel.org>,
        <linux-input@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        Schoefegger Stefan <stefan.schoefegger@...zinger.com>,
        Manfred Schlaegl <manfred.schlaegl@...zinger.com>
Subject: Re: [PATCH] input: edt-ft5x06: increase allowed data range for
 threshold parameter

On 2017-05-11 10:32, Martin Kepplinger wrote:
> On 2017-05-08 18:11, Rob Herring wrote:
>> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
>>> The datasheet and application note does not mention an allowed range for
>>> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
>>> lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
>>> T5x06 touch.
>>>
>>> So, lacking a known lower limit, we increase the range for thresholds,
>>> and set the lower limit to 0. The documentation is updated accordingly.
>>>
>>> Signed-off-by: Schoefegger Stefan <stefan.schoefegger@...zinger.com>
>>> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@...zinger.com>
>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@...zinger.com>
>>> ---
>>>  Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
>>>  Documentation/input/devices/edt-ft5x06.rst                         | 2 +-
>>>  drivers/input/touchscreen/edt-ft5x06.c                             | 2 +-
>>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> Acked-by: Rob Herring <robh@...nel.org>
>>
> 
> Dmitry, any objections or thoughts?

Hey Dmitry, this still applies to today's -next and wouldn't take too
long for you to review :)

thanks

                      martin