linux-kernel - Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170517125144.GD11068@8bytes.org>
Date:   Wed, 17 May 2017 14:51:45 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Honghui Zhang <honghui.zhang@...iatek.com>,
        iommu@...ts.linux-foundation.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/mediatek: include linux/dma-mapping.h

On Thu, May 11, 2017 at 01:35:51PM +0200, Arnd Bergmann wrote:
> The mediatek iommu driver relied on an implicit include of dma-mapping.h,
> but for some reason that is no longer there in 4.12-rc1:
> 
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_finalise':
> drivers/iommu/mtk_iommu_v1.c:233:16: error: implicit declaration of function 'dma_zalloc_coherent'; did you mean 'debug_dma_alloc_coherent'? [-Werror=implicit-function-declaration]
> drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_domain_free':
> drivers/iommu/mtk_iommu_v1.c:265:2: error: implicit declaration of function 'dma_free_coherent'; did you mean 'debug_dma_free_coherent'? [-Werror=implicit-function-declaration]
> 
> This adds an explicit #include to make it build again.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied to iommu/fixes, thanks Arnd.

This was probably another victim of 

	208480b iommu: Remove trace-events include from iommu.h