linux-kernel - Re: [PATCH] char: ipmi: remove unnecessary code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abc2847b-9d83-3fb9-8105-e54524cd56d2@acm.org>
Date:   Wed, 17 May 2017 08:11:22 -0500
From:   Corey Minyard <minyard@....org>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: ipmi: remove unnecessary code

On 05/15/2017 03:46 PM, Gustavo A. R. Silva wrote:
> The array field name in struct i2c_adapter is a fixed size array
> so it can never be NULL.

This was already caught by Colin Ian King, a patch is already queued for 
this.

Thanks,

-corey

> Addresses-Coverity-ID: 1397986
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>   drivers/char/ipmi/ipmi_ssif.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index cca6e5b..df4fea7 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1415,7 +1415,7 @@ static int find_slave_address(struct i2c_client *client, int slave_addr)
>   	list_for_each_entry(info, &ssif_infos, link) {
>   		if (info->binfo.addr != client->addr)
>   			continue;
> -		if (info->adapter_name && client->adapter->name &&
> +		if (info->adapter_name &&
>   		    strcmp_nospace(info->adapter_name,
>   				   client->adapter->name))
>   			continue;