linux-kernel - Re: [PATCH] net: always include tcp.h in sock.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1495033195.6465.20.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 17 May 2017 07:59:55 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: always include tcp.h in sock.c

On Wed, 2017-05-17 at 10:47 +0200, Arnd Bergmann wrote:
> kernelci reports a build regression in the latest 4.12 snapshots
> in configurations without TCP:
> 
> net/core/sock.c: In function 'skb_orphan_partial':
> net/core/sock.c:1810:6: error: implicit declaration of function 'skb_is_tcp_pure_ack' [-Werror=implicit-function-declaration]
> 
> The declaration is simply missing because the header is included
> conditionally. There is no real reason to leave out the header, so
> this just removes the #ifdef.
> 
> Fixes: f6ba8d33cfbb ("netem: fix skb_orphan_partial()")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  net/core/sock.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/net/core/sock.c b/net/core/sock.c
> index e43e71d7856b..727f924b7f91 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -139,10 +139,7 @@
>  
>  #include <trace/events/sock.h>
>  
> -#ifdef CONFIG_INET
>  #include <net/tcp.h>
> -#endif
> -
>  #include <net/busy_poll.h>
>  
>  static DEFINE_MUTEX(proto_list_mutex);


I sent the same patch yesterday.  

https://patchwork.ozlabs.org/patch/763165/

Thanks.